-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list): Accept array of index for selectedIndex API #4124
Conversation
All 679 screenshot tests passed for commit 7420515 vs. |
All 679 screenshot tests passed for commit e5664d9 vs. |
FYI it looks like there are some closure failures to address, and there's a seemingly spurious unit test failure in the last run... Screenshot tests should pass once this is synced with master. |
Codecov Report
@@ Coverage Diff @@
## master #4124 +/- ##
=========================================
Coverage ? 98.49%
=========================================
Files ? 127
Lines ? 5697
Branches ? 761
=========================================
Hits ? 5611
Misses ? 86
Partials ? 0
Continue to review full report at Codecov.
|
All 758 screenshot tests passed for commit 2ea1d3b vs. |
All 758 screenshot tests passed for commit 38a34de vs. |
Before this implementation
selectedIndex
component API (that proxies foundation'ssetSelectedIndex
) use to accept only single number index. This change adds support for multiple indexes that sets the state of checkboxes.New behaviour for checkbox based list
Other changes:
selectedIndex
that returns the current state of selection for all variants.0
for currently focused element and will be reverted to first selected element on focus out of list root.isFocusInsideList
.BREAKING CHANGE: Introduced new adapter
isFocusInsideList
for MDC List for improved accessibility.Fixes #4122
Fixes #3611