Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list): Accept array of index for selectedIndex API #4124

Merged
merged 52 commits into from
Jan 5, 2019
Merged

fix(list): Accept array of index for selectedIndex API #4124

merged 52 commits into from
Jan 5, 2019

Commits on Nov 2, 2018

  1. fix(list): Auto update aria attributes based on check status

    @abhiomkar
    abhiomkar committed Nov 2, 2018
    Configuration menu
    Copy the full SHA
    d585757 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. fix(list): Aria attributes to screenshot pages

    @abhiomkar
    abhiomkar committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    3aa9b8d View commit details
    Browse the repository at this point in the history

  2. fix(list): update aria attributes based on list type

    @abhiomkar
    abhiomkar committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    db41f26 View commit details
    Browse the repository at this point in the history

  3. fix(list): Updated README

    @abhiomkar
    abhiomkar committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    25bacc1 View commit details
    Browse the repository at this point in the history

  4. fix(list): Updated to screenshot head > title

    @abhiomkar
    abhiomkar committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    88ed948 View commit details
    Browse the repository at this point in the history

  5. fix(list): Fix lint

    @abhiomkar
    abhiomkar committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    5a4892a View commit details
    Browse the repository at this point in the history

  6. fix(list): Updated readme to add radio, checkbox sections

    @abhiomkar
    abhiomkar committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    5ce1753 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. fix(list): Update aria for only interactive lists

    @abhiomkar
    abhiomkar committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    b8c818c View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. fix(list): resolve review comments.

    @abhiomkar
    abhiomkar committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    9d5223d View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. fix(list): Abstracted updating aria, classnames into private method f… 

    …or each variant
    @abhiomkar
    abhiomkar committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    ff65398 View commit details
    Browse the repository at this point in the history

  2. fix(list): Update code comments for preselected

    @abhiomkar
    abhiomkar committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    9ebc900 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. fix(list): Updated list unit tests

    @abhiomkar
    abhiomkar committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    0d7091e View commit details
    Browse the repository at this point in the history

  2. fix(list): Updated list README

    @abhiomkar
    abhiomkar committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    73bed5a View commit details
    Browse the repository at this point in the history

  3. fix(list): Code comment

    @abhiomkar
    abhiomkar committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    ad385e8 View commit details
    Browse the repository at this point in the history

  4. fix(list): fix auto toggle on label click

    @abhiomkar
    abhiomkar committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    6228ab8 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. fix(list): Review comments fix

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    cb22dc9 View commit details
    Browse the repository at this point in the history

  2. fix(list): Improved list foundation test coverage - 100%

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    3874baf View commit details
    Browse the repository at this point in the history

  3. fix(list): Test coverage 99.17% => 100%

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    da25244 View commit details
    Browse the repository at this point in the history

  4. fix(list): Additional test for radio aria attribute change

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    5f48c2e View commit details
    Browse the repository at this point in the history

  5. fix(list): README change about tabindex

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    509dbf6 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into fix/list_checkbox_aria

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    d8b4961 View commit details
    Browse the repository at this point in the history

  7. fix(list): Updated README about checkbox role=group

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    45f2f7d View commit details
    Browse the repository at this point in the history

  8. fix(list): trigger CBT

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    57bc9f7 View commit details
    Browse the repository at this point in the history

  9. fix(list): WIP multiple selected index

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    ca1c012 View commit details
    Browse the repository at this point in the history

  10. fix(list): Allow multiple indexes for checkbox

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    19d8ad1 View commit details
    Browse the repository at this point in the history

  11. fix(list): merge master and resolved merge conflicts

    @abhiomkar
    abhiomkar committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    7420515 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. fix(list): simplified setCheckboxAtIndex method

    @abhiomkar
    abhiomkar committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    8b9e0c9 View commit details
    Browse the repository at this point in the history

  2. fix(list): Fixed checkbox checked logic

    @abhiomkar
    abhiomkar committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    8ad3a30 View commit details
    Browse the repository at this point in the history

  3. fix(list): Fixed unit tests, lint errors and closure tests

    @abhiomkar
    abhiomkar committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    f3be4a9 View commit details
    Browse the repository at this point in the history

  4. fix(list): Fix for review comments

    @abhiomkar
    abhiomkar committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    10460be View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. fix(list): Preselected logic for checkbox based list

    @abhiomkar
    abhiomkar committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    8826a00 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. fix(list): Fix selectedIndex for mouse/keyboard interaction

    @abhiomkar
    abhiomkar committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    18c8bb3 View commit details
    Browse the repository at this point in the history

  2. fix(list): set tabindex to 0 when moving focus to target list item

    @abhiomkar
    abhiomkar committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    288191e View commit details
    Browse the repository at this point in the history

  3. fix(list): WIP - Fix existing unit tests.

    @abhiomkar
    abhiomkar committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    0d9ffc5 View commit details
    Browse the repository at this point in the history

  4. fix(list): WIP - Added additional unit tests.

    @abhiomkar
    abhiomkar committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    0cfac92 View commit details
    Browse the repository at this point in the history

  5. fix(list): Set tabindex on first item when none selected on blur.

    @abhiomkar
    abhiomkar committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    ab83f8f View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. fix(list): resolve review comments

    @abhiomkar
    abhiomkar committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    626d98a View commit details
    Browse the repository at this point in the history

  2. fix(list): Added new unit tests and updated a thing about tabindex in… 

    … docs
    @abhiomkar
    abhiomkar committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    e5664d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. fix(list): Removed programmaticSelection_ and replaced with private m… 

    …ethod setSelectedIndexOnAction_
    @abhiomkar
    abhiomkar committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    cd220ed View commit details
    Browse the repository at this point in the history

  2. fix(list): 100% test coverage for list foundation

    @abhiomkar
    abhiomkar committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    351b5e4 View commit details
    Browse the repository at this point in the history

  3. fix(list): 100% test coverage for list component

    @abhiomkar
    abhiomkar committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    6782e93 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2018

  1. fix(list): resolve some review comments

    @abhiomkar
    abhiomkar committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    b30fc91 View commit details
    Browse the repository at this point in the history

  2. fix(list): new unit tests for focus* methods

    @abhiomkar
    abhiomkar committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    df17474 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2018

  1. fix(list): init() => layout()

    @abhiomkar
    abhiomkar committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    32ed86f View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2019

  1. fix(list): README changes as per comments and updated tests

    @abhiomkar
    abhiomkar committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    04f32d8 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. fix(list): move tabindex=0 to selected item

    @abhiomkar
    abhiomkar committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    affc756 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2019

  1. Merge remote-tracking branch 'origin/master' into fix/list_checkbox_s… 

    …electedindex
    @abhiomkar
    abhiomkar committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    cd6e0ff View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into fix/list_checkbox_s… 

    …electedindex
    @abhiomkar
    abhiomkar committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    7370145 View commit details
    Browse the repository at this point in the history

  3. fix(list): Fixed closure errors

    @abhiomkar
    abhiomkar committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    5389d41 View commit details
    Browse the repository at this point in the history

  4. fix(list): fixed unit test for IE11

    @abhiomkar
    abhiomkar committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    e6a3f08 View commit details
    Browse the repository at this point in the history

  5. fix(list): fixed unit test for IE11

    @abhiomkar
    abhiomkar committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    2ea1d3b View commit details
    Browse the repository at this point in the history

  6. fix(list): minor changes on self-review

    @abhiomkar
    abhiomkar committed Jan 5, 2019
    Configuration menu
    Copy the full SHA
    38a34de View commit details
    Browse the repository at this point in the history