Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added icon for *.sigstore.json files #2341

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

okineadev
Copy link
Contributor

No description provided.

PKief and others added 3 commits May 20, 2024 12:29
* feat: ⚙️ Refactor pattern code structure

* Rename type

* feat: update barrels

* feat: update recommended extensions for development

* Add comment
Change from `[ ]` to real checkbox ☑️
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief PKief force-pushed the main branch 2 times, most recently from e748540 to b209d61 Compare May 23, 2024 11:57
Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@okineadev

This comment was marked as abuse.

@PKief
Copy link
Member

PKief commented Jun 12, 2024

@okineadev
Let's be a bit patient and please try to avoid sending such images. An alternative could be asking in a way which is more friendly and professional like "I was wondering what's the status of this pull request" or "Is there anything I can do to speed up the progress on this PR".

Please check the following points:

  1. It would be helpful if you can check if the icon you're providing is pixel perfect.
  2. Provide some information in the description of this PR why do you need that icon
  3. Add some link to the provided tool or language this icon is about

Thanks a lot.

@PKief PKief force-pushed the main branch 2 times, most recently from eeb4f0e to b2e0fe4 Compare June 12, 2024 20:23
@okineadev
Copy link
Contributor Author

Well, you're boring...
Okay, sorry for the long delay

Prehistory

I was in Poland at work, picking strawberries, I had to get up at 4 in the morning and work until 6 in the evening, lunch was 2 hours, so as you can see, there was not much time to do GitHub

https://youtu.be/0HaVEs8v_hU?si=qefM3lEbYRN8gF7d&t=22


image

As you can see, during this time the contributions came to nothing, only sometimes there was time to do something.

However, I made money and am already at home, so I will sponsor you again soon 🙃

GitHub added artifact attestations feature, see https://github.blog/changelog/2024-05-02-artifact-attestations-public-beta/

Sigstore source files have the extension *.sigstore.json

Here is an example of such an attestation: https://github.com/instoll-sh/instoll/attestations/1203860

So I think it would be great to add an icon for such files

I took the icon from Material Icons

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

Copy link

Preview

Thank you for creating a pull request. This preview shows you how your changes will look on the different themes:

Generated Preview

You can find more information how to contribute in the contribution guidelines.

@PKief PKief merged commit 0bc889a into material-extensions:main Jun 30, 2024
3 checks passed
Copy link

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the marketplace.

@okineadev okineadev deleted the sigstore-icon branch July 19, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants