Add tiling to CrystalToolkitScene #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eSlider to optionally use the props.
…ng and maxTiling arguments
…lkitScene component.
# Conflicts: # src/app.tsx # src/components/crystal-toolkit/CrystalToolkitScene/CrystalToolkitScene.tsx # src/components/crystal-toolkit/scene/animation-slider.tsx
# Conflicts: # .babelrc # src/app.tsx
|
Thanks @orionarcher, had a chance to double-check this and looks to be in very good shape :) Will be trying to integrate upstream very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tiling to CrystalToolkitScene.
In particular, it add two new props
tiling, which dynamically controls the tiling of the crystal, andmaxTiling, which decides how large the tiling can grow.This PR also add the TilingVisualization app that provides a demonstration of the new functionality by linking the tiling to three RangeSliders.
To be tiled, crystal-toolkit scene jsons must contain the
latticeparameter, which is a new addition to the crystal-toolkit package.A diagram of the logic in this PR can be found here.
TODO:
implement animation