Skip to content

Revert "Tiling fixes" #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Revert "Tiling fixes" #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/components/crystal-toolkit/scene/Scene.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,8 @@ export default class Scene {
private debugDOMElement?,
cameraState?: CameraState
) {
this.tiling = tiling || 0;
this.maxTiling = maxTiling || [0, 0, 0];
this.tiling = tiling;
this.maxTiling = maxTiling;
this.arrayOfTileRoots = Scene.getEmptyTilesArray([
this.maxTiling,
this.maxTiling,
Expand Down Expand Up @@ -522,10 +522,6 @@ export default class Scene {
return tiles;
};

const _alternateTiles = (x: number) => {
return (-1) ** (x + 1) * Math.trunc((x + 1) / 2);
};

const emptyLattice = [
[0, 0, 0],
[0, 0, 0],
Expand All @@ -551,9 +547,7 @@ export default class Scene {
this.arrayOfTileRoots[x][y][z].push(tileRootObject);

let tileOffsets: number[][] = lattice.map((vector: number[], index: number) => {
return vector.map((x: number) => {
return x * _alternateTiles(tile[index]);
});
return vector.map((x: number) => x * tile[index]);
});
traverseScene(sceneJson, tileRootObject, tileOffsets, '');
}
Expand Down