Skip to content

Revert "Add tiling to CrystalToolkitScene" #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Revert "Add tiling to CrystalToolkitScene" #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
"plugins": [
"@babel/transform-runtime"
]
}
}
68 changes: 0 additions & 68 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"react": "^16.14.0",
"react-aria-menubutton": "^7.0.1",
"react-collapsible": "^2.8.3",
"react-compound-slider": "^3.4.0",
"react-data-table-component": "^6.11.6",
"react-dom": "^16.14.0",
"react-graph-vis": "^1.0.5",
Expand Down
5 changes: 0 additions & 5 deletions src/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ import { Sandbox } from './pages/Sandbox';
import { SynthesisExplorer } from './pages/SynthesisExplorer';
import { MPContribsSearch } from './pages/MPContribsSearch';
import { CatalystExplorer } from './pages/CatalystExplorer';
import { TilingVisualization } from './pages/TilingVisualization';
import { Navbar } from './components/navigation/Navbar';
import periodicTableImage from './assets/images/periodictable.png';
import { MofExplorer } from './pages/MofExplorer';
Expand All @@ -46,7 +45,6 @@ ReactDOM.render(
<Link to="/phasediagram">Phase Diagram</Link>
<Link to="/contribs">Contributions</Link>
<Link to="/crystal">Crystal Structure</Link>
<Link to="/tiling">Tiling Visualization</Link>
<Link to="/sandbox">Sandbox</Link>
</div>
<section>
Expand Down Expand Up @@ -87,9 +85,6 @@ ReactDOM.render(
<Route path="/matscholar">
<MatscholarMaterialsExplorer />
</Route>
<Route path="/tiling">
<TilingVisualization />
</Route>
<Route path="/">
<MaterialsExplorer />
</Route>
Expand Down
13 changes: 0 additions & 13 deletions src/components/crystal-toolkit/CrystalToolkitScene/CrystalToolkitScene.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,6 @@ export interface CrystalToolkitSceneProps {
*/
settings?: any;

/**
* the dynamic tiling, to be updated in scene.
*/
tiling?: number[];
/**
* the maximum size of the tiling, controls render size
*/
maxTiling?: number;
/**
* Hide/show nodes in scene by its name (key), value is 1 to show the node
* and 0 to hide it.
Expand Down Expand Up @@ -379,8 +371,6 @@ export const CrystalToolkitScene: React.FC<CrystalToolkitSceneProps> = ({
props.settings,
props.inletSize,
props.inletPadding,
props.tiling,
props.maxTiling,
(objects) => {
if (props.onObjectClicked) {
props.onObjectClicked(objects);
Expand Down Expand Up @@ -443,9 +433,6 @@ export const CrystalToolkitScene: React.FC<CrystalToolkitSceneProps> = ({
() => scene.current!.updateInsetSettings(props.inletSize!, props.inletPadding!, props.axisView),
[props.inletSize, props.inletPadding, props.axisView]
);
useEffect(() => {
scene.current!.updateTiles(props.tiling);
}, [props.tiling]);

useEffect(() => {
scene.current!.resizeRendererToDisplaySize();
Expand Down
Loading