Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nonsensical cast_to_email and cast_to_uri functions #3564

Merged
merged 3 commits into from
May 9, 2024

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented May 3, 2024

Fixes #3555

Updated list of valid cast functions for email and uri types:

mathesar=# \df mathesar_types.cast_to_email
                                  List of functions
     Schema     |     Name      |   Result data type   | Argument data types  | Type 
----------------+---------------+----------------------+----------------------+------
 mathesar_types | cast_to_email | mathesar_types.email | character            | func
 mathesar_types | cast_to_email | mathesar_types.email | character varying    | func
 mathesar_types | cast_to_email | mathesar_types.email | mathesar_types.email | func
 mathesar_types | cast_to_email | mathesar_types.email | text                 | func
(4 rows)

mathesar=# \df mathesar_types.cast_to_uri
                               List of functions
     Schema     |    Name     |  Result data type  | Argument data types | Type 
----------------+-------------+--------------------+---------------------+------
 mathesar_types | cast_to_uri | mathesar_types.uri | character           | func
 mathesar_types | cast_to_uri | mathesar_types.uri | character varying   | func
 mathesar_types | cast_to_uri | mathesar_types.uri | mathesar_types.uri  | func
 mathesar_types | cast_to_uri | mathesar_types.uri | text                | func
(4 rows)

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Comment on lines -67 to -71
def create_date_casts(engine):
type_body_map = _get_date_type_body_map()
create_cast_functions(PostgresType.DATE, type_body_map, engine)


Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we create identical cast functions in create_datetime_casts(), I've removed this function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@Anish9901 Anish9901 requested a review from mathemancer May 3, 2024 14:24
@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label May 3, 2024
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resulting cast functions look like the right ones. But, there's a problem.

You need to either:

  • restore these, but make a different category for installing casts, or
  • Use different logic in the record selector search function (see db/records/operations/relevance.py)

The problem is that if we merge this PR, you won't really be able to find records by searching email or URL columns.

Comment on lines -67 to -71
def create_date_casts(engine):
type_body_map = _get_date_type_body_map()
create_cast_functions(PostgresType.DATE, type_body_map, engine)


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

Comment on lines -13 to -14
MathesarCustomType.URI,
MathesarCustomType.EMAIL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these with no other changes results in breaking searching for emails and URLs in the record selector.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh I see, thanks for pointing that out!

@mathemancer mathemancer added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels May 8, 2024
@mathemancer mathemancer assigned Anish9901 and unassigned mathemancer May 8, 2024
@Anish9901 Anish9901 requested a review from mathemancer May 8, 2024 10:39
@Anish9901 Anish9901 added this to the Beta milestone May 8, 2024
@Anish9901 Anish9901 assigned mathemancer and unassigned Anish9901 May 8, 2024
@Anish9901 Anish9901 added pr-status: review A PR awaiting review and removed pr-status: revision A PR awaiting follow-up work from its author after review labels May 8, 2024
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is good to go. Thanks!

@mathemancer mathemancer enabled auto-merge May 9, 2024 05:20
@mathemancer mathemancer added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit b4de3de May 9, 2024
38 checks passed
@mathemancer mathemancer deleted the rm_cast_func branch May 9, 2024 05:52
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation creates nonsensical cast functions
3 participants