-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Col delete func #3586
Col delete func #3586
Conversation
@Anish9901 Should be ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me @mathemancer, please fix the name of the test that I've pointed down below and merge this.
assert result == 3 | ||
|
||
|
||
def test_get_column_info_for_table(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function name doesn't make sense.
Fixes #3583
Adds a
columns.delete
function to the RPC endpoint.Technical details
The function is documented in its docstring and the Mathesar docs, and said documentation should be sufficient.
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin