Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Money type domains WIP #662

Closed
wants to merge 13 commits into from
Closed

Money type domains WIP #662

wants to merge 13 commits into from

Conversation

mathemancer
Copy link
Contributor

Fixes #417

Technical details

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kgodey
Copy link
Contributor

kgodey commented Sep 14, 2021

@mathemancer I thought we were going to leave the multi-currency MONEY type in so we could build a UI for it in the future? It looks like this PR deletes it.

I made the following issues to build a design/frontend for it:

@mathemancer
Copy link
Contributor Author

@mathemancer I thought we were going to leave the multi-currency MONEY type in so we could build a UI for it in the future? It looks like this PR deletes it.

It leaves it in, but avoids hooking it up to the API. It's also removed from "supported types", since that would end up getting picked up by the API code. This is the reason for the removal of all the associated tests.

@github-actions
Copy link

This pull request has not been updated in 45 days and is being marked as stale. It will automatically be closed in 30 days if not updated by then.

@github-actions github-actions bot added the stale label Nov 26, 2021
@kgodey
Copy link
Contributor

kgodey commented Nov 26, 2021

@mathemancer do you want to close this PR since we're going to be implementing money via display options?

@mathemancer
Copy link
Contributor Author

@mathemancer do you want to close this PR since we're going to be implementing money via display options?

Good idea, closing.

@mathemancer mathemancer deleted the money_type_domains branch November 30, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Backend work for Mathesar money custom type
2 participants