Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend email filtering #893

Closed
wants to merge 4 commits into from

Conversation

dmos62
Copy link
Contributor

@dmos62 dmos62 commented Dec 16, 2021

Fixes #410

Implements EmailDomainEquals and EmailDomainContains string matching predicates that are applyable only to email Mathesar types.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dmos62 dmos62 added work: backend Related to Python, Django, and simple SQL needs: unblocking Blocked by other work pr-status: review A PR awaiting review labels Dec 16, 2021
@dmos62 dmos62 self-assigned this Dec 16, 2021
@dmos62 dmos62 changed the title Backend filtering email Backend filtering for email columns Dec 16, 2021
@dmos62 dmos62 changed the title Backend filtering for email columns Backend filtering for the email type Dec 16, 2021
@kgodey
Copy link
Contributor

kgodey commented Dec 16, 2021

@dmos62 Please make the base branch of this PR whatever you branched off of instead of master.

@dmos62 dmos62 changed the base branch from master to backend-filtering-text December 16, 2021 16:37
@dmos62 dmos62 changed the title Backend filtering for the email type Backend email filtering Dec 20, 2021
@kgodey
Copy link
Contributor

kgodey commented Jan 28, 2022

@dmos62 Can we close this PR since it's pretty out of date?

@dmos62 dmos62 closed this Jan 29, 2022
@kgodey kgodey deleted the backend-filtering-email branch January 29, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: unblocking Blocked by other work pr-status: review A PR awaiting review work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Implement filtering options for the email type
2 participants