Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Equal/Unequal for Strings better. #1128

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Handle Equal/Unequal for Strings better. #1128

merged 1 commit into from
Jan 27, 2021

Conversation

rocky
Copy link
Member

@rocky rocky commented Jan 26, 2021

Fixes #1127

@GarkGarcia GarkGarcia self-requested a review January 27, 2021 14:56
mmatera
mmatera approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@mmatera mmatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky rocky merged commit b459d5b into master Jan 27, 2021
@rocky rocky deleted the equal-unequal branch February 7, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatera mmatera mmatera approved these changes

@GarkGarcia GarkGarcia GarkGarcia approved these changes

Assignees

@mmatera mmatera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Equal["11",11] raise an unhandled exception
3 participants
@rocky @mmatera @GarkGarcia