Update handling of braket bars so that the enclosing braket can be more accurately found. (mathjax/MathJax#3164) #1041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where the
BraketMethods.Bar()
function doesn't find the enclosingbraket
item properly when there are certain types of enclosing elements (like style or color changes).To do this, we add a function to the
Stack
object to get its current height (the number of elements on the stack), and save that in thebraket
item'senv
object, which will be available in the parser stack'senv
object. Then theBraketMethods.Bar()
function can useparser.stack.env.braketItem
to find the matchingbraket
item without having to look through the stack items to find it. (The current approach doesn't work if there are intervening items other than anover
item).We also set the
braket
package priority so that it is searched before thebase
package, guaranteeing that thebraket
function for|
is used rather than thebase
one.Finally, we fix a few comments along the way.
Resolves issue mathjax/MathJax#3164.