Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow (embellished) operators in \underset, \overset, and \underoverset to specify accent="true" #894

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Feb 7, 2023

Currently, \underset, \overset, and \underoverset force accent="false" on mo elements that are set on top or bottom of the base. This PR allows a (possibly embellished) operator that has an explicit accent="true" to set the accent or accentunder attributes of the munder, mover, or munderover that is produced. That allows, for example

\underset{\mmlToken{mo}[accent="true"]{⎵}}{abcabc}

to properly handle the underbrace as an accent (i.e., without reducing its scale). (Without this PR, the accent always gets accent="false", and so is reduced in size. There is an additional bug where that causes the stretchy character not to stretch sufficiently, but that is treated in the fix-stretchy-widths branch.)

@dpvc dpvc requested a review from zorkow February 7, 2023 21:30
@dpvc dpvc added this to the v4.0 milestone Feb 7, 2023
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit da04308 into develop Mar 3, 2023
@dpvc dpvc deleted the under-overset-accents branch March 3, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants