Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array optional position argument [b] appears to not work #2394

Closed
tylercecil opened this issue Apr 1, 2020 · 2 comments
Closed

array optional position argument [b] appears to not work #2394

tylercecil opened this issue Apr 1, 2020 · 2 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3
Milestone

Comments

@tylercecil
Copy link

Issue Summary

My apologies in advance if I am mistaken / making no sense / filing in the wrong place.

This JS Bin shows a minimal example. You can see that top aligned seems to work, however bottom align works the same as top (center align works fine).

By chance, I noticed 2.7.5 seems to have the correct behavior. I am totally ignorant of the Mathjax project and its history, though, so... all it tells me is that there was a time when it worked.

I found #2083, which may be related?

Technical details:

  • MathJax Version: 3.0.1
  • Client OS: Arch Linux
  • Browser: Chromium 80.0.3987.149 Arch Linux
@dpvc
Copy link
Member

dpvc commented Apr 1, 2020

It turns out that there is an "off by one" error when determining the line to align at when working from the bottom of the array (so if you use more rows, you would see the alignment on the second to last row rather than the last one).

I have made a pull request to resolve the issue. Thanks for reporting it!

@tylercecil
Copy link
Author

Thanks so much for the quick reply and fix! Glad it was simple enough.

dpvc added a commit to mathjax/MathJax-src that referenced this issue Apr 3, 2020
Fix row alignment for negative row numbers.  (mathjax/MathJax#2394)
@dpvc dpvc added Merged Merged into develop branch Fixed and removed Ready for Review labels Apr 3, 2020
@dpvc dpvc closed this as completed Apr 10, 2020
@dpvc dpvc removed the Merged Merged into develop branch label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3
Projects
None yet
Development

No branches or pull requests

2 participants