Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TeX input] support for nested text macros #2846

Closed
pkra opened this issue Mar 14, 2022 · 5 comments
Closed

[TeX input] support for nested text macros #2846

pkra opened this issue Mar 14, 2022 · 5 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.2
Milestone
3.2.1

Comments

@pkra
Copy link
Contributor

pkra commented Mar 14, 2022 •
edited
Loading

Authors do things like $ \text{for \textit{some} values } x > 0$.

The textmacros extension gives me \textit is only supported in math mode. "Real" TeX is fine with this.

Could it be supported?
@pkra pkra changed the title support for nested text macros [TeX input] support for nested text macros Mar 14, 2022
@pkra
Copy link
Contributor Author

pkra commented Mar 14, 2022

Huh, on a second try this is working for me. Weird. Sorry for the noise!

@pkra pkra closed this as completed Mar 14, 2022
@pkra
Copy link
Contributor Author

pkra commented Mar 14, 2022

Ah, my problem was different yet -- I had misread my error messages and the example had textup inside text.

It seems textup is missing from textmacros. Is that intentional?

@pkra pkra mentioned this issue Mar 14, 2022
Closed
@dpvc
Copy link
Member

dpvc commented Mar 14, 2022

It seems textup is missing from textmacros. Is that intentional?

No. \textup and \textnormal where added to the base macros after textmacros was written, and just didn't get added in there. I'll make a PR to do it.

Do you need a patch for now?

dpvc added a commit to mathjax/MathJax-src that referenced this issue Mar 14, 2022
@dpvc
Add \textup and \textnormal to allowed textmacros. (mathjax/MathJax#2846
ef9d566 
)
@dpvc dpvc mentioned this issue Mar 14, 2022
Merged
@pkra
Copy link
Contributor Author

pkra commented Mar 15, 2022

No. \textup and \textnormal where added to the base macros after textmacros was written, and just didn't get added in there. I'll make a PR to do it.

Ah, ok!

Do you need a patch for now?

No, I just rewrote things to textrm (which is good enough for me).

Should this be re-opened?

@pkra pkra reopened this Mar 15, 2022
@pkra
Copy link
Contributor Author

pkra commented Mar 15, 2022

Oops. I re-opened. Sorry.

@dpvc dpvc added Ready for Review Accepted Issue has been reproduced by MathJax team Test Needed v3 labels Mar 20, 2022
@dpvc dpvc added this to the 3.2.1 milestone Mar 20, 2022
dpvc added a commit to mathjax/MathJax-src that referenced this issue Apr 18, 2022
@dpvc
Merge pull request #790 from mathjax/issue2846
f924d35 
Add \textup and \textnormal to allowed textmacros. (mathjax/MathJax#2846)
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Apr 18, 2022
@dpvc dpvc added Fixed v3.2 and removed Merged Merged into develop branch labels Jun 1, 2022
@dpvc dpvc closed this as completed Jun 1, 2022
@MonsterDruide1 MonsterDruide1 mentioned this issue Aug 28, 2023
Closed
4 tasks
@samul-1 samul-1 mentioned this issue May 24, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue May 24, 2024
Open
@samul-1 samul-1 mentioned this issue Sep 9, 2024
Open
@X-oss-byte X-oss-byte mentioned this issue Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3 v3.2
Projects
None yet
Milestone
3.2.1
Development

No branches or pull requests
2 participants
@pkra @dpvc