Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHTML-preview leaves preview if custom script tags are used directly #975

Closed
pkra opened this issue Dec 15, 2014 · 5 comments
Closed

CHTML-preview leaves preview if custom script tags are used directly #975

pkra opened this issue Dec 15, 2014 · 5 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.5
Milestone
MathJax v2.5

Comments

@pkra
Copy link
Contributor

pkra commented Dec 15, 2014

Live example at http://jsbin.com/pakoxe/2/edit
@pkra
Copy link
Contributor Author

pkra commented Dec 16, 2014

An empty MathJax_Preview element prevents the problem; see http://jsbin.com/pakoxe/3/edit

@dpvc dpvc added the Accepted Issue has been reproduced by MathJax team label Dec 17, 2014
@dpvc dpvc added this to the MathJax 2.5 milestone Dec 22, 2014
dpvc added a commit to dpvc/MathJax that referenced this issue Dec 26, 2014
@dpvc
Save preview in script.MathJax to fix issue mathjax#975.
501b96c
@dpvc
Copy link
Member

dpvc commented Dec 26, 2014

It turns out that the preview element is recorded before the input jax runs, and since the CHTML-preview is inserted during the input post-filter, it was being added too late to be recorded.

I have foxed the problem in the CHTML-preview branch of my fork of MathJax. You can merge it with v2.5-alpha, and repack.

@dpvc
Copy link
Member

dpvc commented Dec 30, 2014

=> Merged.

@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Dec 30, 2014
@dpvc dpvc closed this as completed Dec 30, 2014
dpvc added a commit to mathjax/MathJax-test that referenced this issue Jan 13, 2015
@dpvc
Add test for preview being removed with CHTML-preview (mathjax/MathJa…
b23ef82 
…x#975).
@dpvc
Copy link
Member

dpvc commented Jan 13, 2015

=> In Testsuite

Parsing/issue975.html

@pkra
Copy link
Contributor Author

pkra commented Jan 14, 2015

I think I marked this as Needs Documentation to remember to document the CHTML-preview extension; this has been done as part of mathjax/MathJax-docs#83 so I'm removing the tag.

@dpvc dpvc added Fixed v2.5 and removed Merged Merged into develop branch labels Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Available v2.5
Projects
None yet
Milestone
MathJax v2.5
Development

No branches or pull requests
2 participants
@pkra @dpvc