Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:SignBytes representation of empty string data field in the event-… #1016

Merged
merged 4 commits into from
Jul 22, 2023

Conversation

VAIBHAVJINDAL3012
Copy link
Contributor

@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 commented Jun 29, 2023

Description

In v0.2.11 -> v0.2.12 transition, algorithm for the string conversion of HexBytes for the data field of event-record was changed. It impacted the conversion in the case when the HexBytes represented the empty string.Due to this it was causing the sync issue. This PR includes changes which rectified that issue "
I would like to thank @svenski123 for reporting this issue and also putting his effort to research out the best solution for this.
#1004

Changes

  • Bugfix (non-breaking change that solves an issue)
  • [.] Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Nodes audience

This PR change should be applied to all the nodes who are syncing from the scatch

Checklist

  • [.] I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • [.] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.02 ⚠️

Comparison is base (784f0f0) 75.41% compared to head (ad15687) 75.40%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1016      +/-   ##
===========================================
- Coverage    75.41%   75.40%   -0.02%     
===========================================
  Files           49       49              
  Lines         5296     5309      +13     
===========================================
+ Hits          3994     4003       +9     
- Misses        1068     1071       +3     
- Partials       234      235       +1     
Impacted Files Coverage Δ
auth/ante.go 81.42% <80.00%> (-0.46%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Raneet10 and others added 2 commits June 30, 2023 10:32
Replace use of literal "pruning" with same-valued constant flagPruning as used elsewhere in the file.
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 marked this pull request as ready for review July 21, 2023 14:00
@VAIBHAVJINDAL3012 VAIBHAVJINDAL3012 merged commit 329efab into develop Jul 22, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants