Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mardizzone/pos-1040: dev: add: commands to stop/start AWS EC2 instances using terraform with express-cli #133

Merged
merged 8 commits into from
Jan 9, 2023

Conversation

marcello33
Copy link
Contributor

Description

This PR provides two new commands for express-cli to remotely stop and start the AWS EC2 VM instances associated with a deployed devnet.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 marked this pull request as ready for review December 21, 2022 10:24
@marcello33 marcello33 requested a review from a team December 21, 2022 12:04
README.md Show resolved Hide resolved
@marcello33 marcello33 merged commit 69bfeda into master Jan 9, 2023
@marcello33 marcello33 deleted the mardizzone/pos-1040 branch November 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants