Fix splits KeyError while downloading #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently downloading will fail with following error:
```
gplaycli --verbose --progress -d com.pushbullet.android
[INFO] GPlayCli version 3.29 [Python3.8.2]
[INFO] Configuration file is /home/guoqiao/git/gplaycli/gplaycli.conf
[INFO] Device is bacon
[INFO] Using credentials to connect to API
[INFO] Using plaintext password
[INFO] 1 / 1 com.pushbullet.android
/usr/local/lib/python3.8/dist-packages/gpapi/googleplay.py:634: RuntimeWarning: Unexpected end-group tag: Not all data was converted
response = googleplay_pb2.ResponseWrapper.FromString(response.content)
Traceback (most recent call last):
File "/usr/local/bin/gplaycli", line 11, in <module>
load_entry_point('gplaycli', 'console_scripts', 'gplaycli')()
File "/home/guoqiao/git/gplaycli/gplaycli/gplaycli.py", line 659, in main
cli.download(args.download)
File "/home/guoqiao/git/gplaycli/gplaycli/hooks.py", line 11, in check_connection
return function(self, *args, **kwargs)
File "/home/guoqiao/git/gplaycli/gplaycli/gplaycli.py", line 290, in download
splits = data_iter['splits']
KeyError: 'splits'
```
Use `get` to avoid dict `KeyError` while `splits` not exists in `data_iter`.
Fixes: matlink#272
Signed-off-by: Qiao Guo <guoqiao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently downloading will fail with following error:
Use
getto avoid dictKeyErrorwhilesplitsnot exists indata_iter.Fixes: #272
Signed-off-by: Qiao Guo guoqiao@gmail.com