ENH: Color-filled Counties #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a keyword argument to allow for color filling counties. Achieved by conververting LineCollection to PolyCollection
|
Looks good - please add a Changelog entry and I will merge. |
|
Sorry it took so long. With the shutdown, this must have slipped through my email... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses what I consider somewhat of a corner-case when the user defines a "fill continents" color and then calls the "drawcounties" method. Currently, island portions of counties are drawn, but not filled in. This pull requests allows a user to supply a "facecolor" keyword argument that fills in the counties. Therefore, when specified, portions of counties that are (for example) islands results in the islands being filled.
This was done by converting the counties from a linecollection to a polycollection and then setting the facecolor argument. The default behavior remains the same (e.g., no filling).
Additionally, this will allow for industrious users to create choropleth maps by supplying lists of colors to fill counties with as the "set_facecolor" method of a polycollection will accept lists.