makes netCDF4 optional for examples/run_all.py #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you do not have netCDF4 installed, some tests will give ImportErrors. This patch makes netCDF4 optional for run_all.py. It imports netCDF4, if that package is not available, it removes tests that require netCDF4. There may be some of the tests in the lines above the try-statement that could be put below the except-statement. I did not look at that aspect.
|
Could you include a message stating that some tests are being removed due to the netCDF4 package not being importable? |
|
Are you wanting me to print that message for the user? Or are you wanting me to make this comment "# remove tests requiring netCDF4" a little more descriptive? |
|
a message to the user so that they know that not all of the tests are being On Mon, Nov 30, 2015 at 4:01 PM, Micah Cochran notifications@github.com
|
WeatherGod
added a commit
that referenced
this pull request
Dec 14, 2015
makes netCDF4 optional for examples/run_all.py
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you do not have netCDF4 installed, some example tests will give ImportErrors.
This patch makes netCDF4 optional for run_all.py. It imports netCDF4, if that package is not available, it removes tests that require netCDF4.
There may be some of the tests in the lines above the try-statement that could be put below the except-statement. I did not look at that aspect.