Skip to content

Fix doc bug #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 1, 2016
Merged

Fix doc bug #258

merged 2 commits into from
Feb 1, 2016

Conversation

jpli
Copy link
Contributor

@jpli jpli commented Jan 30, 2016

I think it's better to get the extra "plt.show()" removed since it dangles below the land-sea mask image created by the first "plt.show()" statement.

WeatherGod added a commit that referenced this pull request Feb 1, 2016
@WeatherGod WeatherGod merged commit 89508c8 into matplotlib:master Feb 1, 2016
@WeatherGod
Copy link
Member

Thanks!

@jpli jpli deleted the fix-doc-bug branch February 4, 2016 13:09
@jpli
Copy link
Contributor Author

jpli commented Feb 4, 2016

You are welcome. Shall I open another pull request on gh-pages to reflect the change on the documentation site?

@WeatherGod
Copy link
Member

actually, no, I don't think that is where it needs to be done. I only
recently taken over this project, so I am still trying to figure out
exactly how deployment of the docs are done. I think it is all being
handled through ReadTheDocs, which I have zero experience with, nor do I
have an account on.

On Thu, Feb 4, 2016 at 8:15 AM, Li Jiapeng notifications@github.com wrote:

You are welcome. Shall I open another pull request on gh-pages to reflect
the change on the documentation site?


Reply to this email directly or view it on GitHub
#258 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants