Corrects the following error: #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.7/site-packages/mpl_toolkits/basemap/__init__.py", line 4358, in wmsimage
return self.imshow(imread(io.BytesIO(urllib2.urlopen(img.url).read()),
AttributeError: 'ResponseWrapper' object has no attribute 'url'
It might have something to do with an owslib update
|
Any idea how many versions owslib has supported this particular syntax? |
|
Unfortunately not. I just tried to display a wms image with an all updated anaconda installation and debugged the wmsimage function. I didn’t build the package by hand to control the behaviour. But it solved my problem. |
|
Ok, I did some digging into the history of owslib. The usage of calling ".read()" on the returned object dates back to at least 2009. I'd say that is sufficient backwards compatibility. |
WeatherGod
added a commit
that referenced
this pull request
Feb 24, 2016
Corrects the following error:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.7/site-packages/mpl_toolkits/basemap/init.py", line 4358, in wmsimage
return self.imshow(imread(io.BytesIO(urllib2.urlopen(img.url).read()),
AttributeError: 'ResponseWrapper' object has no attribute 'url'
It might have something to do with an owslib update