Update version number code for pyproj #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update code to reflect changes to pyproj API that simplify reporting version numbers. Specifically, pyproj pull request 60, pyproj4/pyproj#60
|
Great, thanks for the updates. Should Cartopy get similar updates as well? |
|
Thank you. Cartopy doesn't use pyproj, so it wouldn't be exactly the same. Cartopy requires PROJ.4 (version 4.9.0 or above), which is they use their own Cython wrapper code _crs.pyx. I could probably code something similar to what I did for pyproj. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code to reflect changes to pyproj API that simplify reporting version numbers. Specifically, pyproj pull request 60, pyproj4/pyproj#60
The geodesic library will report 'Unknown'. See the "nightly" version to see the changes working and reporting a version (due to it pulling the development version of pyproj from github).