Update data #320
Merged
Update data #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only readboundaries_shp.py actually wrote data in a format that basemap could read. It looks like readboundaries.py has not actually been used to produce boundary data in a _very_ long time. Instead, it's been produced from the GSHHS shapefiles.
New GSHHS versions simplify long national/state borders that are perfectly linear in geographic space. However, basemap assumes that these lines are already subsampled, and does the interpolation in between the two points in geographic space. This leads to extreme errors for long borders with only two points (e.g. the US/Canada border). Old GSHHS versions stored interpolated versions, so this is an issue that didn't come up in the past. To get around this, we'll interpolate long linear segments and store the interpolated versions.
|
Hmm, just noticed that I left out the changes to some of the other data like lsmask. |
|
There we go, now both PRs modify all the same files. I am not concerned that the lsmask data came from v2.3.5 of the GSHHG data given that the only difference between v2.3.5 and v2.3.6 is fixing some errors with the Antarctica data, which I believe Joe already took into account. |
|
The tests have passed. Since this PR was originally Joe's with just a tiny little fix, I am going to go ahead with a self-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A remade version of #311 using GSHHG 2.3.6. Also drops out all of that PR's commits that changed the data in order to keep the repo size down. Also fixes a bug discovered during testing of that PR.
Huge thanks to @joferkington for his critical work in #311, without which this would not have been possible!