Skip to content

Rate limit text updates #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Rate limit text updates #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions js/src/mpl_widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ var MPLCanvasView = widgets.DOMWidgetView.extend({

mouse_event: function(name) {
var that = this;
var last_update = 0;
return function(event) {
var canvas_pos = utils.get_mouse_position(event);

Expand All @@ -391,12 +392,18 @@ var MPLCanvasView = widgets.DOMWidgetView.extend({
that.canvas_div.focus();
}

var x = canvas_pos.x * that.ratio;
var y = canvas_pos.y * that.ratio;
// Rate-limit the position text updates so that we don't overwhelm the
// system.
if (Date.now() > last_update + 40) {
last_update = Date.now();

that.send_message(name, {x: x, y: y, button: event.button,
step: event.step,
guiEvent: utils.get_simple_keys(event)});
var x = canvas_pos.x * that.ratio;
var y = canvas_pos.y * that.ratio;

that.send_message(name, {x: x, y: y, button: event.button,
step: event.step,
guiEvent: utils.get_simple_keys(event)});
}

/* This prevents the web browser from automatically changing to
* the text insertion cursor when the button is pressed. We want
Expand Down