Tweaks to resizing handle #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are a couple tweaks to the resizing handle. These are mainly designed to make things behave reasonably when matplotlib rendering times are longer.
First, ignore mouse events when resizing. I found that when there are delays in image resizing, the cursor sometimes crosses the image which triggers a ton of mouse events to update the x/y text at the bottom of the image and everything grinds to a halt.
Second, when there is a long delay in rendering, with the current implementation it is very hard to see where you are dragging the figure to because the boundaries of the image only update whenever the image itself does. I changed this so that the boundaries update on the client as you drag the mouse. This is my preferred behavior, and is also what the notebook backend currently does.