Fix mouse position computation #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes mouse position computation, fixing resizing issues in complicated front-ends like custom Voila templates (where the scroll level of the page is not the document scroll, for example with a fixed top bar). Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
fix_mouse_relative_position
branch
from
1728bbd to
3be8051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes mouse position computation (relative to the canvas). This fixes resizing issues in complicated front-ends like custom Voila templates, where the scroll level of the page is not the document scroll, for example with a fixed top bar.
It was actually useless to depend on the scroll level, as all we need to know is the mouse relative position to the canvas, viewport coordinates are enough.