Fix building when Gtk doesn't support version check #1900
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick patch to fix a build problem that I ran into this morning when updating matplotlib via pyston on my Ubuntu 12 laptop. I haven't dug into this deeply, but this
is my current understanding (and the patch does fix the build problem on my laptop):
python setup.py install --user
fails with
AttributeError: 'gi.repository.Gtk' object has no attribute 'get_major_version'
for old versions of Gtk without support for introspection
(specifically, on Ubuntu 12 with python-gtk2 2.24.0-3)
This commit silently drops the associated exceptions for the two Gtk
version checks in setupext.py