Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #3687 to 1.4.x #3699

Merged
merged 1 commit into from
Oct 27, 2014

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Oct 22, 2014

No description provided.

@mdboom mdboom modified the milestones: v1.4.x, v1.4.2 Oct 22, 2014
@mdboom mdboom self-assigned this Oct 22, 2014
tacaswell added a commit that referenced this pull request Oct 27, 2014
@tacaswell tacaswell merged commit c29a117 into matplotlib:v1.4.x Oct 27, 2014
@mwaskom
Copy link

mwaskom commented Nov 21, 2014

Is there a timeline for a 1.4.3 release with this fix?

@tacaswell
Copy link
Member

The current target date is Feb 1 with an RC in early/mid January.

@mwaskom
Copy link

mwaskom commented Nov 21, 2014

Any hope for something sooner? This bug completely breaks seaborn.

mwaskom added a commit to mwaskom/seaborn that referenced this pull request Nov 21, 2014
This is an unpleasant hack, but this is also a nasty bug and matplotlib
apparently won't be releasing a fix for a few months:
matplotlib/matplotlib#3699

This closes #344
@danielballan
Copy link
Contributor

+1 for considering an urgent 1.4.3 release to fix this.

Also, would it make sense to test downstream libraries like seaborn in mpl's test suite so that mpl would at least alerted to major breakages like this?

@mwaskom
Copy link

mwaskom commented Nov 24, 2014

+1 for considering an urgent 1.4.3 release to fix this.

FWIW I have cut point release with a hacky workaround for this bug, so it's no longer quite so urgent.

Also, would it make sense to test downstream libraries like seaborn in mpl's test suite so that mpl would at least alerted to major breakages like this?

It actually probably makes a bit more sense for me to have one of the Travis builds run on matplotlib's github master.

@danielballan
Copy link
Contributor

OK, great, I discovered 0.5.1 after I commented. Thanks, @mwaskom.

@tacaswell
Copy link
Member

Given the discussion of v2.0 coming soon and off-line discussions with
@mdboom and @efiring about doing bug-fix releases more often it probably
will happen sooner rather than later (mostly contingent on my finding the
bandwidth to do the release).

I don't think mpl should get into the business of testing down-stream
libraries, that way lies madness.

In this case we also had a failure in the automated tests (there is a
tolerance on them to deal with slight variations in font rendering which
allowed the test that should have caught this to pass) so it probably
would not have helped in this case anyway.

On Mon Nov 24 2014 at 10:50:31 AM Dan Allan notifications@github.com
wrote:

+1 for considering an urgent 1.4.3 release to fix this.

Also, would it make sense to test downstream libraries like seaborn in
mpl's test suite so that mpl would at least alerted to major breakages like
this?


Reply to this email directly or view it on GitHub
#3699 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants