Merge convert-numeric into encodings #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts the list of dictionary into a Pandas DataFrame or if an url is given, it downloads the data and loads it into a DataFrame
Converts the list of dictionary into a Pandas DataFrame or if an url is given, it downloads the data and loads it into a DataFrame
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 3 +2
Lines 7 66 +59
Branches 0 13 +13
=====================================
+ Hits 7 66 +59
Continue to review full report at Codecov.
|
|
#6 is also merged now. |
Altair handles this case by itself, so mplaltair does not need to think of these cases.
* Refactors tests * Adds more tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary merge of PR #4 into PR #5 as we discussed in the meeting today.
TODOs:
-Update test_convert.py to work with the new Altair chart parsing system
-write tests for _data._locate_channel_dtype
-I’m thinking _utils._fetch() isn’t necessary at this point, but I didn’t have time this evening to look into it