Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTD config #195

Merged
merged 5 commits into from Apr 1, 2023
Merged

Add RTD config #195

merged 5 commits into from Apr 1, 2023

Conversation

ConorMacBride
Copy link
Member

No description provided.

.readthedocs.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
.readthedocs.yaml Outdated Show resolved Hide resolved
docs/rtd_environment.yaml Outdated Show resolved Hide resolved
Copy link
Member Author

@ConorMacBride ConorMacBride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove all the conda stuff. Just copied the config from astropy or sunpy 😄

@astrofrog
Copy link
Collaborator

Huh you are right astropy has that now? When did that happen?!

@astrofrog
Copy link
Collaborator

But do we actually need graphviz here?

@astrofrog
Copy link
Collaborator

Just pushed a commit to remove the conda stuff - that was only needed in astropy/sunpy because old graphviz versions had a bug that affected them - but we don't even use graphviz here so should be fine without.

Copy link
Collaborator

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of pushing a few commits to simplify the config, hope that's ok! I think we could merge this now assuming the CI passes.

Some of the boxes on the front page of the docs are empty but that's unrelated to this PR which is just fixing the config.

Maybe we don't have to use this template if our content doesn't quite fit in?

@ConorMacBride ConorMacBride merged commit d5ed60c into matplotlib:main Apr 1, 2023
24 checks passed
@ConorMacBride ConorMacBride deleted the rtd branch April 1, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants