Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions on how to reproduce viridis #58

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

stefanv
Copy link
Contributor

@stefanv stefanv commented Oct 17, 2022

/cc @njsmith

@mfisher87
Copy link
Collaborator

The instructions aren't working at 0a7ea27, which looks to me like a bug:

$ python -m viscm --uniform-space buggy-CAM02-UCS -m Bezier edit /tmp/option_d.py
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/robatt/Projects/_external/viscm/viscm/__main__.py", line 8, in <module>
    cli()
  File "/home/robatt/Projects/_external/viscm/viscm/cli.py", line 114, in cli
    mainwindow = gui.EditorWindow(figureCanvas, v)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/robatt/Projects/_external/viscm/viscm/gui.py", line 1157, in __init__
    self.max_slider.setValue(viscm_editor.max_Jp)
TypeError: setValue(self, a0: int): argument 1 has unexpected type 'float'

I'd like to write a unit test for this and get it fixed prior to release.

Copy link
Collaborator

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #72 is merged, the command in this documentation works on Pythons >=3.10 🎉

@mfisher87 mfisher87 merged commit bc6d63c into matplotlib:main Jun 6, 2023
1 check passed
@mfisher87 mfisher87 added this to the v0.10 milestone Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants