Prometheus #13
Prometheus #13
Conversation
- The plugin supports resending messages after server recovery.
|
|
||
| INITIAL_TIMEOUT = 5 | ||
| TIMEOUT_INCREMENT = 5 | ||
| MAX_TIMEOUT = 60 * 5 |
There was a problem hiding this comment.
Units on these please e.g. MAX_TIMEOUT_MS
|
This looks really cool, thanks! Few small comments / queries but this is looking good. It's worth noting that currently this plugin will accept requests from anyone, whether or not they are actually Prometheus. At worst, this could be a potential spam vector. It might be nice to add in some form of shared secret (as a query parameter) similar to the Jenkins plugin: https://github.com/matrix-org/Matrix-NEB/blob/master/plugins/jenkins.py#L198 - It's a little bit fiddly because you need to store the token somewhere on startup. I don't really mind too much about this, so don't feel like you have to do this in order for this PR to land. I'm more interested in the line comments I've left. |
|
LGTM, thanks! |
This plugin makes it possible to redirect alert messages coming from prometheus to different rooms
it also queues messages when the server is down and sends them when the server is up again.