This repository was archived by the owner on Nov 25, 2024. It is now read-only.
Run gofmt on dendrite - apply go 1.17 preferred build tags #2021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.17 introduces new way to add build tags - see release notes, section
//go:build lines
. Runninggofmt -w .
in Dendrite directory yields changes in this PR. Apparently,golangci-lint run
fails because of that with output below (assuming go 1.17). I didn't find an option to configure it and make it non fatal. This failing logs are annoying when linting locally. We also should catch up witch language changes.Pull Request Checklist
sytest-whitelist
as specified in docs/sytest.mdSigned-off-by:
Piotr Kozimor <p1996k@gmail.com>