Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Spec violation with push rules / incompatible with FluffyChat #2882

Closed
Mikaela opened this issue Nov 17, 2022 · 0 comments · Fixed by #2918
Closed

Potential Spec violation with push rules / incompatible with FluffyChat #2882

Mikaela opened this issue Nov 17, 2022 · 0 comments · Fixed by #2918
Labels
F-Push spec-compliance Fix something that doesn't comply with the specs T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@Mikaela
Copy link

Mikaela commented Nov 17, 2022

Background information

Homeserver: dendrite.matrix.org

neilalexander accepted opening a tracking issue also at Dendrite in case it's Dendrite and not Famedly SDK (most notably used in FluffyChat) at fault. Their issue: https://gitlab.com/famedly/company/frontend/famedlysdk/-/issues/349

I apologise for not knowing enough to open a more detailed issue.

Description

  • What is the problem: FluffyChat cannot sync with Dendrite.
  • Who is affected: FluffyChat users
  • How is this bug manifesting: FluffyChat never finishes syncing
  • When did this first appear: FluffyChat development buids for version that were stabilized today.

Steps to reproduce

  1. Login to Dendrite homeserver using FlufyChat.
  2. Observe it not syncing.
@Mikaela Mikaela mentioned this issue Nov 21, 2022
Closed
webzwo0i added a commit to webzwo0i/dendrite that referenced this issue Nov 27, 2022
@webzwo0i
Don't omit pattern key if empty.
8a852ba 
This is needed to match state events with an empty value. Fixes matrix-org#2882
@webzwo0i webzwo0i mentioned this issue Nov 27, 2022
Closed
@kegsay kegsay added spec-compliance Fix something that doesn't comply with the specs T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. F-Push labels Dec 6, 2022
@S7evinK S7evinK mentioned this issue Dec 20, 2022
Merged
S7evinK added a commit that referenced this issue Dec 23, 2022
@S7evinK
Pushrule tweaks, make pattern non-optional on EventMatchCondition (…
f47515e 
…#2918)

This should fix #2882
(Tested with FluffyChat 1.7.1)
Also adds tests that the predefined push rules (as per the spec) is what
we have in Dendrite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F-Push spec-compliance Fix something that doesn't comply with the specs T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
2 participants
@Mikaela @kegsay