Move GetVersion to client from federation_client #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested changes
Mar 18, 2019
client.go
Outdated
| ) (res Version, err error) { | ||
| // Construct a request for version information | ||
| url := url.URL{ | ||
| Scheme: "https", |
There was a problem hiding this comment.
matrix? Check the other methods in this file.
client.go
Outdated
|
|
||
| // GetVersion gets the version information of a homeserver. | ||
| // See https://matrix.org/docs/spec/server_server/r0.1.1.html#get-matrix-federation-v1-version | ||
| func (fc *Client) GetVersion( |
There was a problem hiding this comment.
this should be before the things it calls (ie, DoRequestAndParseResponse), and anyway conceptually it sits alongside GetServerKeys etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
GetVersiona client function rather than a federation function.