Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third Party Endpoints don't check access tokens #76

Closed
anoadragon453 opened this issue Jul 27, 2018 · 2 comments · Fixed by #409
Closed

Third Party Endpoints don't check access tokens #76

anoadragon453 opened this issue Jul 27, 2018 · 2 comments · Fixed by #409
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.

Comments

@anoadragon453
Copy link
Member

A homeserver is able to request third party lookup information without requiring an access_token.

This will break existing stuff, also a spec PR should be made first.
@turt2live turt2live added the bug label Mar 20, 2019
@Half-Shot
Copy link
Contributor

There is already an auth spec for this https://matrix.org/docs/spec/application_service/r0.1.2#third-party-networks, so synapse needs to get itself sorted out.

@Half-Shot
Copy link
Contributor

This was completed a while ago from our side, but needs enabling by default. For that, we need Synapse to send access tokens.

@Half-Shot Half-Shot added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems. S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed bug labels May 13, 2022
@Half-Shot Half-Shot mentioned this issue May 16, 2022
Closed
@Half-Shot Half-Shot mentioned this issue May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove option to disable authentication of the 3pid endpoints matrix-org/matrix-appservice-bridge
3 participants
@turt2live @anoadragon453 @Half-Shot