Publicity sync speedup #1111
Merged
Publicity sync speedup #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benparsons
approved these changes
Aug 14, 2020
| @@ -454,6 +452,8 @@ export class IrcBridge { | |||
| this.ircServers.push(server); | |||
| } | |||
|
|
|||
| this.clientPool = new ClientPool(this, this.dataStore); | |||
There was a problem hiding this comment.
it has a (somewhat hard to see) dependency on the configured server list (provided by IrcBridge.getServers()).
There was a problem hiding this comment.
Oh except I failed to mention that this PR has a dependency on #1091, which is where the change came from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do a O(N) operation across all bridged channels if any of the modes change, which while safe was becoming computationally far too expensive to use.
This change makes it so that we only compute the publicity changes for the channel being changed, which should be safe enough.