Fix thundering herd problem with debouncer #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
approved these changes
Jan 27, 2021
jaller94
reviewed
Jan 27, 2021
| @@ -61,15 +61,14 @@ export class QuitDebouncer { | |||
| // Nobody to debounce, yay. | |||
| return; | |||
| } | |||
| const delay = Math.max(server.getQuitDebounceDelayMinMs(), server.getQuitDebounceDelayMaxMs() * Math.random()); | |||
| log.info(`Will attempt to reconnect users for ${channel} after ${delay}ms`) | |||
There was a problem hiding this comment.
This line uses delay which is no longer defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the debouncer code that would often delay the debounce for the min period rather than a random period. This change ensures that two debounce efforts are hopefully not processed at the same time.