Check the banReason before banning a user. #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Mar 28, 2022
jaller94
approved these changes
Mar 28, 2022
jaller94
reviewed
Mar 28, 2022
src/irc/ClientPool.ts
Outdated
| @@ -558,8 +558,10 @@ export class ClientPool { | |||
| for (const [userId, client] of set.userIds.entries()) { | |||
| try { | |||
| const banReason = this.ircBridge.matrixBanSyncer?.isUserBanned(userId); | |||
| log.warn(`Killing ${userId} client connection due - user is banned (${banReason})`); | |||
| await client.kill('User was banned'); | |||
| if (banReason) { | |||
There was a problem hiding this comment.
I'd prefer some test that also kills on empty string.
While the matrixBanSyncer will default empty strings to "No reason given", only the return value false states that the user isn't banned.
Suggested change
| if (banReason) { | |
| if (typeof banReason === 'string') { |
Co-authored-by: Christian Paul <christianp@matrix.org>
|
(You were right about |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing users to get banned erroneously