Fix e2e error flakiness #1803
Merged
Fix e2e error flakiness #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1802
This tackles this from two different directions. First: we now clean up a test's dependencies in series rather than parallel, which makes it error a bit less. Second, we send a message after reconnection and await this message. The reason is that currently the test will finish execution before it's had a chance to send the "Okay, I'm reconnecting you" Matrix message, which means the homeserver may be stopped before it has a chance to do so, and the wheels all come off.
Due to matrix-org/complement#720, I've added a small retry loop for creating the homeserver deployment.
This hopefully should make our tests generally more reliable.