Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC1717: common definitions for key verification methods #1717

Merged
merged 10 commits into from
Jun 2, 2019
Merged

MSC1717: common definitions for key verification methods #1717

merged 10 commits into from
Jun 2, 2019

Conversation

uhoreg
Copy link
Member

@uhoreg uhoreg commented Nov 13, 2018 •
edited
Loading

@uhoreg uhoreg added proposal A matrix spec change proposal T-Core labels Nov 13, 2018
@uhoreg uhoreg added the e2e label Nov 14, 2018
@uhoreg uhoreg changed the title MSC: common definitions for key verification methods MSC1717: common definitions for key verification methods Nov 15, 2018
turt2live
turt2live reviewed Nov 26, 2018
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if this proposal also covered an example key verification method itself, or at least linked to a proposal that does so.

proposals/1717-key_verification.md Outdated Show resolved Hide resolved
@uhoreg
Copy link
Member Author

uhoreg commented Mar 18, 2019

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Mar 18, 2019 •
edited by richvdh
Loading

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Mar 18, 2019
@turt2live turt2live self-requested a review March 18, 2019 15:56
turt2live
turt2live reviewed Mar 19, 2019
View reviewed changes
proposals/1717-key_verification.md Outdated Show resolved Hide resolved
proposals/1717-key_verification.md

Properties:

- `from_device` (string): Required. The device ID of the device requesting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I wonder if we should bake this into the spec as a requirement for the sending server to stamp it, similar to the sender already stamped on it. Probably something for a different proposal though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've been frustrated by the fact that you don't automatically get the sending device. But, as you say, something for a different proposal.

@dbkr
Copy link
Member

dbkr commented May 24, 2019

Some of this is duplicated from 1267 (eg. the human readable reason string stuff which I commented on over on 1267). Seems like it really belongs in here and we should take some of that stuff out of 1267 and have it refer to here instead?

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels May 28, 2019
@mscbot
Copy link
Collaborator

mscbot commented May 28, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@turt2live turt2live self-assigned this May 31, 2019
@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jun 2, 2019
@mscbot
Copy link
Collaborator

mscbot commented Jun 2, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit dda7afa into matrix-org:master Jun 2, 2019
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period proposal-in-review labels Jun 2, 2019
turt2live added a commit that referenced this pull request Jun 4, 2019
@turt2live
Spec SAS verification and the common key verification framework
a3364ff 
Reference implementations:
* https://gitlab.matrix.org/matrix-org/olm/commit/94f664e7256215f33639dbbad6aaf87ada082a9f
* matrix-org/matrix-react-sdk#2461
* matrix-org/matrix-js-sdk#818
* matrix-org/matrix-react-sdk#2596
* matrix-org/matrix-js-sdk#837

Proposals:
* [MSC1717](#1717)
* [MSC1267](#1267)

No alterations to either proposal have been made intentionally here.
@turt2live turt2live mentioned this pull request Jun 4, 2019
Merged
@turt2live
Copy link
Member

Spec PR: #2072

@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jun 4, 2019
@turt2live
Copy link
Member

merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Jun 7, 2019
@turt2live turt2live added the kind:maintenance MSC which clarifies/updates existing spec label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live left review comments

Assignees

@turt2live turt2live

Labels
disposition-merge e2e kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@uhoreg @mscbot @dbkr @turt2live @anoadragon453