Skip to content

/matrix-doc

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2324: Facilitating early releases of software dependent on spec #2324

Merged
merged 9 commits into from Dec 3, 2019
+124 −0

Conversation

@turt2live
Copy link
Member

turt2live commented Oct 18, 2019 •
edited

Rendered
@turt2live
What if we allowed people to ship sooner?
Loading status checks…
f496046
@turt2live turt2live changed the title Facilitating early releases of software dependent on spec MSC2324: Facilitating early releases of software dependent on spec Oct 18, 2019
@turt2live
Assign number
Loading status checks…
330d94a
@richvdh
richvdh approved these changes Oct 18, 2019
View changes
Copy link
Member

richvdh left a comment

lgtm, though a couple of suggestions
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@turt2live
Clarifications for developers
Loading status checks…
bc44d31
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n
ara4n reviewed Oct 18, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@hawkowl
hawkowl reviewed Oct 21, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@turt2live
turt2live reviewed Oct 24, 2019
View changes
proposals/2324-when-to-ship.md Show resolved Hide resolved
turt2live and others added 4 commits Oct 24, 2019
@turt2live @ara4n
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0052a2b 
Co-Authored-By: Matthew Hodgson <matthew@matrix.org>
@turt2live
Fix line length
3b10cc8
@turt2live
Expand on unstable endpoint inheritance
Loading status checks…
55d2cc4
@turt2live
Clarify that feature flags are not required for everything
Loading status checks…
46c7d15
@jryans jryans mentioned this pull request Oct 28, 2019
Closed
@richvdh
richvdh reviewed Oct 29, 2019
View changes
proposals/2324-when-to-ship.md Show resolved Hide resolved
@turt2live
turt2live reviewed Nov 1, 2019
View changes
proposals/2324-when-to-ship.md Show resolved Hide resolved
@jryans jryans mentioned this pull request Nov 5, 2019
Open
@uhoreg
uhoreg reviewed Nov 14, 2019
View changes
Copy link
Member

uhoreg left a comment

Looks mostly good with just a couple of nits
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@turt2live turt2live self-assigned this Nov 14, 2019
@turt2live
Add a bunch of procedural words to the proposal
Loading status checks…
cd80cac 
Mostly stuff that has been discussed in comments, a bit of common sense, and a hint of clarity.
@turt2live

This comment has been minimized.

Sign in to view
Copy link
Member Author

turt2live commented Nov 15, 2019

Bearing in mind that I've doubled the length of the proposal in cd80cac (please read this!)...

Let's get this thing on the road.

@mscbot fcp merge
@mscbot

This comment has been minimized.

Sign in to view
Copy link
Collaborator

mscbot commented Nov 15, 2019 •
edited by erikjohnston

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.
@ara4n
ara4n reviewed Nov 21, 2019
View changes
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@ara4n

This comment has been minimized.

Sign in to view
Copy link
Member

ara4n commented Nov 21, 2019

this lgtm - only one minor tweak to try to resolve the "you don't have to implement before you call FCP, but FCP requires evidence typically in the form of an implementation" paradox.
@turt2live @ara4n
Update proposals/2324-when-to-ship.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c98922b 
Co-Authored-By: Matthew Hodgson <matthew@matrix.org>
@richvdh
richvdh reviewed Nov 28, 2019
View changes
proposals/2324-when-to-ship.md
To reiterate:

* Implementations MUST NOT use stable endpoints before the MSC is in the spec. This
includes NOT using stable endpoints post-FCP.

This comment has been minimized.

Sign in to view
Copy link
@richvdh

richvdh Nov 28, 2019

Member

Between fcp and spec release, presumably?

This comment has been minimized.

Sign in to view
Copy link
@turt2live

turt2live Nov 28, 2019

Author Member

yup
@mscbot

This comment has been minimized.

Sign in to view
Copy link
Collaborator

mscbot commented Nov 28, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔
@mscbot

This comment has been minimized.

Sign in to view
Copy link
Collaborator

mscbot commented Dec 3, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.
@anoadragon453 anoadragon453 merged commit 1cf322b into master Dec 3, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #1051 passed (5 minutes, 11 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg

@ara4n ara4n

@richvdh richvdh

@hawkowl hawkowl

@erikjohnston erikjohnston

@KitsuneRal KitsuneRal

Assignees

@turt2live turt2live

Labels
disposition-merge finished-final-comment-period process proposal
Projects
None yet
Milestone
No milestone
9 participants
@turt2live @mscbot @ara4n @uhoreg @richvdh @hawkowl @erikjohnston @KitsuneRal @anoadragon453
You can’t perform that action at this time.