Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSC2324: Facilitating early releases of software dependent on spec #2324

Merged
merged 9 commits into from
Dec 3, 2019
Merged

MSC2324: Facilitating early releases of software dependent on spec #2324

merged 9 commits into from
Dec 3, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Oct 18, 2019 •
edited by richvdh
Loading

@turt2live turt2live changed the title Facilitating early releases of software dependent on spec MSC2324: Facilitating early releases of software dependent on spec Oct 18, 2019
@turt2live turt2live added process Related to the spec process itself (MSC process) proposal A matrix spec change proposal proposal-in-review labels Oct 18, 2019
richvdh
richvdh approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, though a couple of suggestions

proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@jryans jryans mentioned this pull request Oct 28, 2019
Closed
@jryans jryans mentioned this pull request Nov 5, 2019
Closed
uhoreg
uhoreg reviewed Nov 14, 2019
View reviewed changes
Copy link
Member

@uhoreg uhoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good with just a couple of nits

proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
proposals/2324-when-to-ship.md Outdated Show resolved Hide resolved
@turt2live turt2live self-assigned this Nov 14, 2019
@turt2live
Add a bunch of procedural words to the proposal
cd80cac 
Mostly stuff that has been discussed in comments, a bit of common sense, and a hint of clarity.
@mscbot
Copy link
Collaborator

mscbot commented Nov 15, 2019 •
edited by erikjohnston
Loading

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot mscbot added proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. disposition-merge labels Nov 15, 2019
@ara4n
Copy link
Member

ara4n commented Nov 21, 2019

this lgtm - only one minor tweak to try to resolve the "you don't have to implement before you call FCP, but FCP requires evidence typically in the form of an implementation" paradox.

@turt2live @ara4n
Update proposals/2324-when-to-ship.md
c98922b 
Co-Authored-By: Matthew Hodgson <matthew@matrix.org>
richvdh
richvdh reviewed Nov 28, 2019
View reviewed changes
proposals/2324-when-to-ship.md
To reiterate:

* Implementations MUST NOT use stable endpoints before the MSC is in the spec. This
includes NOT using stable endpoints post-FCP.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between fcp and spec release, presumably?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Nov 28, 2019
@mscbot
Copy link
Collaborator

mscbot commented Nov 28, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added finished-final-comment-period and removed final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Dec 3, 2019
@mscbot
Copy link
Collaborator

mscbot commented Dec 3, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@anoadragon453 anoadragon453 merged commit 1cf322b into master Dec 3, 2019
@richvdh
Copy link
Member

richvdh commented Jan 2, 2020

It would be good to get https://matrix.org/docs/spec/proposals updated to reflect this.

@richvdh richvdh added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 2, 2020
@turt2live turt2live mentioned this pull request Feb 12, 2020
Open
turt2live added a commit that referenced this pull request Feb 13, 2020
@turt2live
Attempt to convert MSC2324 to reality
3ee9a7d 
We've been using this in practice for a while now, so we should document it more officially. 

MSC: #2324
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Feb 13, 2020
@turt2live turt2live mentioned this pull request Feb 13, 2020
Merged
@turt2live
Copy link
Member Author

Spec PR: #2433

@turt2live turt2live deleted the travis/msc/shipit branch February 13, 2020 04:04
@turt2live turt2live added the kind:core MSC which is critical to the protocol's success label Apr 20, 2020
@turt2live
Copy link
Member Author

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels May 21, 2020
@tulir tulir mentioned this pull request Jan 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhoreg uhoreg uhoreg left review comments

@ara4n ara4n ara4n left review comments

@richvdh richvdh richvdh approved these changes

@hawkowl hawkowl hawkowl left review comments

@erikjohnston erikjohnston erikjohnston left review comments

@KitsuneRal KitsuneRal KitsuneRal left review comments

Assignees

@turt2live turt2live

Labels
disposition-merge kind:core MSC which is critical to the protocol's success merged A proposal whose PR has merged into the spec! process Related to the spec process itself (MSC process) proposal A matrix spec change proposal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@turt2live @mscbot @ara4n @richvdh @uhoreg @hawkowl @erikjohnston @KitsuneRal @anoadragon453