Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2334 - Change default room version to v5 #2334

Merged

Conversation

@aaronraimist aaronraimist changed the title MSC2333 - Change default room version to v5 MSC2334 - Change default room version to v5 Oct 30, 2019
@aaronraimist aaronraimist force-pushed the aaronraimist:MSC2333-default-room-version-v5 branch from d633007 to f61b547 Oct 30, 2019
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist aaronraimist force-pushed the aaronraimist:MSC2333-default-room-version-v5 branch from f61b547 to 6270983 Oct 30, 2019
Copy link
Member

turt2live left a comment

overall seems very sensible to me - it has indeed been long enough.

proposals/2334-default-room-version-v5.md Outdated Show resolved Hide resolved
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 30, 2019

thanks!

This is fairly straightforward and is in fact the plan we agreed upon before, so:

@mscbot fcp merge

@mscbot

This comment has been minimized.

Copy link
Collaborator

mscbot commented Oct 30, 2019

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once at least 75% of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@mscbot

This comment has been minimized.

Copy link
Collaborator

mscbot commented Oct 31, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot

This comment has been minimized.

Copy link
Collaborator

mscbot commented Nov 5, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit fed0b95 into matrix-org:master Nov 5, 2019
7 checks passed
7 checks passed
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
turt2live added a commit that referenced this pull request Nov 5, 2019
As per [MSC2334](#2334)
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Nov 5, 2019

Spec PR: #2347

@aaronraimist aaronraimist deleted the aaronraimist:MSC2333-default-room-version-v5 branch Nov 5, 2019
@turt2live turt2live added merged and removed spec-pr-in-review labels Nov 5, 2019
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Nov 5, 2019

Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.