Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MXSpaceService: Update public space creation initial state events #1061

Merged
merged 8 commits into from
Apr 7, 2021

Conversation

SBiOSoftWhare
Copy link
Contributor

self.initialStateEvents = @[];
}

NSString *stateEventTypeString = stateEvent[@"type"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use MXJSONModelSetString to manage var type check.


/// MXRoomStateEventBuilder enables to build initial state events
@objcMembers
public class MXRoomStateEventBuilder: NSObject {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call it MXRoomInitialStateEventBuilder?
It only creates such type of JSON, not JSON for full room state events.

@SBiOSoftWhare SBiOSoftWhare merged commit 676d061 into spaces Apr 7, 2021
@SBiOSoftWhare SBiOSoftWhare deleted the public_space_config_2 branch April 7, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants