MXCrossSigning: Gossip the master key #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| [self.crypto.store storeSecret:secret withSecretId:MXSecretId.crossSigningMaster]; | ||
| dispatch_group_leave(onPrivateKeysReceivedGroup); | ||
| } |
There was a problem hiding this comment.
We are missing balance call to dispatch_group_leave(onPrivateKeysReceivedGroup); when isSecretValid == NO for each key.
From dispatch_group_enter documentation:
A call to this function must be balanced with a call to dispatch_group_leave.
There was a problem hiding this comment.
The current algorithm seems correct to me. If the secret is not valid, we need to wait for another device to send another secret.
This blocks return NO to keep receiving secrets.
SBiOSoftWhare
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes element-hq/element-ios/issues/3346