Support for blacklisting unverified devices, both per-room and globally #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main thing outstanding here seems to be persistence of the settings. |
I see that matrix-org/matrix-react-sdk#636 contains functionality to persist the user setting, but we still need to save the room setting somehow. |
|
persisting roomsettings is done in https://github.com/matrix-org/matrix-react-sdk/pull/636/files#diff-7810353d2ee5218b7242e81423030433R279 no? |
ahhh, that's meant to be a per-user setting - got it |
|
@richvdh now the other PR has landed, this is unblocked. is this LGTMed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #335, which should be landed before this review makes any sense.
Twinned with matrix-org/matrix-react-sdk#636.
Hopefully solves element-hq/element-web#2313