Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra checks to avoid release script blowing up mid-process. #749

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Extra checks to avoid release script blowing up mid-process. #749

merged 2 commits into from
Dec 12, 2018

Conversation

bwindels
Copy link
Contributor

No description provided.

@bwindels bwindels requested a review from a team September 28, 2018 10:54
@turt2live
Copy link
Member

@bwindels is this still needed?

@bwindels
Copy link
Contributor Author

huh, I thought we merged this already. Yeah, still makes sense for it to go in.

@bwindels bwindels merged commit 2d3669b into develop Dec 12, 2018
dbkr added a commit to element-hq/element-web that referenced this pull request Jan 17, 2019
@dbkr
Add npm user arg for matrix-org/matrix-js-sdk#749
021d6c5
@t3chguy t3chguy deleted the bwindels/releaseimprovements branch May 10, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwindels @turt2live @dbkr