Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate camelCase config options #11261

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Deprecate camelCase config options #11261

merged 1 commit into from
Jul 14, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 14, 2023 •
edited by github-actions bot

For element-hq/element-web#25800

Here's what your changelog entry will look like:

馃 Deprecations

  • Deprecate camelCase config options (#11261).

@t3chguy t3chguy mentioned this pull request Jul 14, 2023
Merged
@t3chguy t3chguy marked this pull request as ready for review July 14, 2023 08:05
@t3chguy t3chguy requested a review from a team as a code owner July 14, 2023 08:05
germain-gg
germain-gg reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, but can you add context to the pull request?
Why this gets deprecated? Maybe linking it to an issue explaining the ins and outs?

@t3chguy
Copy link
Member Author

t3chguy commented Jul 14, 2023

@germain-gg see element-hq/element-web#25800 (now linked in OP)

@t3chguy t3chguy requested a review from germain-gg July 14, 2023 08:38
@t3chguy t3chguy added this pull request to the merge queue Jul 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 14, 2023
@t3chguy t3chguy added this pull request to the merge queue Jul 14, 2023
Merged via the queue into develop with commit 3a784c7 Jul 14, 2023
82 checks passed
@t3chguy t3chguy deleted the t3chguy/depr-camel branch July 14, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@justjanne justjanne justjanne approved these changes

Assignees
No one assigned
Labels
T-Deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t3chguy @germain-gg @justjanne